Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Surrogate pairs is split across spans #139

Closed
palemieux opened this issue Dec 3, 2018 · 0 comments
Closed

Surrogate pairs is split across spans #139

palemieux opened this issue Dec 3, 2018 · 0 comments
Assignees
@palemieux
Labels
1.0 1.1 bug PR open
Milestone
1.0.2

Comments

@palemieux
Copy link
Contributor

chatAt can return surrogates, which need to be wrapped within the same span at

imscJS/src/main/js/html.js

Line 304 in 07692da

span.textContent = isd_element.text.charAt(j); 

<?xml version="1.0" encoding="UTF-8"?>
<tt:tt xmlns:tt="http://www.w3.org/ns/ttml" 
    xmlns:ebutts="urn:ebu:tt:style" 
    xmlns:ttp="http://www.w3.org/ns/ttml#parameter" 
    xmlns="http://www.w3.org/ns/ttml" 
    xmlns:tts="http://www.w3.org/ns/ttml#styling" 
    xmlns:ttm="http://www.w3.org/ns/ttml#metadata" ttp:profile="http://www.w3.org/ns/ttml/profile/imsc1/text" xml:lang="en">
    <body>
        <div>
            <p tts:backgroundColor="black" ebutts:linePadding="0.1c" tts:color="yellow">
        Hello, I am Mork from Ork 😀
            </p>
        </div>
    </body>
</tt:tt>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
1.0 1.1 bug PR open
Projects
None yet
Milestone
1.0.2
Development

No branches or pull requests
1 participant
@palemieux