Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrain applicability of certain style properties to ruby container spans #156

Closed
palemieux opened this issue Jul 11, 2019 · 2 comments · Fixed by #157
Closed

Constrain applicability of certain style properties to ruby container spans #156

palemieux opened this issue Jul 11, 2019 · 2 comments · Fixed by #157
Assignees
@palemieux
Labels
bug PR open
Milestone
1.1

Comments

@palemieux
Copy link
Contributor

palemieux commented Jul 11, 2019 •
edited
Loading

The following character-based style properties should not apply to any ruby container spans:

  • color
  • textCombine
  • textDecoration
  • textEmphasis
  • textOutline
  • textShadow

See w3c/ttml2#1043
@palemieux palemieux added the bug label Jul 11, 2019
@palemieux palemieux self-assigned this Jul 11, 2019
@palemieux palemieux added this to the 1.1 milestone Jul 11, 2019
@palemieux
Copy link
Contributor Author

In addition, the applicability code at

imscJS/src/main/js/isd.js

Line 428 in c6a2f6e

if (qnameb === imscStyles.byName.rubyAlign.qname) {
is broken since rubyAlign should be removed from elements beyond ruby container spans.

palemieux added a commit that referenced this issue Jul 12, 2019
@palemieux
Fix applicability of character-based style properties to ruby contain…
3ca79a3 
…er spans (#156)
@palemieux palemieux mentioned this issue Jul 12, 2019
Merged
@palemieux palemieux changed the title Constrained applicability of certain style properties to ruby container spans Constrain applicability of certain style properties to ruby container spans Jul 13, 2019
@palemieux
Copy link
Contributor Author

The following does not prune text nodes from ruby container spans:

imscJS/src/main/js/doc.js

Line 178 in c6a2f6e

} else if (estack[0] instanceof Span || estack[0] instanceof P) {

palemieux added a commit that referenced this issue Jul 15, 2019
@palemieux
Address #156 (comment)
0ef2c91
palemieux added a commit that referenced this issue Jul 17, 2019
@palemieux
* Constrain applicability of character-based style properties to ruby…
0906d17 
… container spans (#156)

* Prune ruby container spans text nodes (#156)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@palemieux palemieux

Labels
bug PR open
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Fix applicability of character-based style properties to ruby container spans sandflow/imscJS
1 participant
@palemieux