-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextOutline works incorrectly #174
Comments
Can you provide a test file, current render and preferred render? |
Sure IMSC_textOutline_issue.zip. The IMSC_textOutine_using_shadows file contains emulation ot the textOutline by myself. Using the IMSC_textOutline_using_textOutline file you can see the current render. |
Thanks. I have seen text outline typically used with white text and surrounded by a small black outline, so we should make sure this new scheme works well in that case. |
@dmkyr20 Does the following capture what you have in mind? https://codepen.io/palemieux/pen/WNQRqJP @dkneeland Thoughts on changing |
@palemieux Hi, yes. I think it looks better than the current text outline render |
That looks like a worthwhile improvement to me, especially experimenting with changing the background and foreground colour to be the same, e.g. white/yellow/lime/cyan/red foreground on white or black background. |
@dmkyr20 See PR at #175. Also deployed at http://sandflow.com/imsc1_1/index.html |
@palemieux Hey, It looks great. Thanks) Could I ask one more thing. If I add a blur radius for text-outline the text-outline stops working. Could you fix it? Text-outline documentation: https://www.w3.org/TR/ttml/#style-attribute-textOutline |
@dmkyr20 Thanks for the feedback.
What is the objective of using blur? |
@palemieux Oh, sorry. That's my mistake) Thanks for help) |
Hey, I have used the textOutput option for my IMSC file, but it doesn't work with two parameters as documented. Furthermore, I know that CSS doesn't have text-outline, but maybe you can use something like this. I have tried this method and the result looks better, as for me. Also, in this case, you can add blur-radius parameter.
imscJS/src/main/js/html.js
Line 1464 in 8d45889
Thanks :)
The text was updated successfully, but these errors were encountered: