Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextOutline works incorrectly #174

Closed
dmkyr20 opened this issue Apr 14, 2020 · 10 comments
Closed

TextOutline works incorrectly #174

dmkyr20 opened this issue Apr 14, 2020 · 10 comments
Assignees

Comments

@dmkyr20
Copy link

dmkyr20 commented Apr 14, 2020

Hey, I have used the textOutput option for my IMSC file, but it doesn't work with two parameters as documented. Furthermore, I know that CSS doesn't have text-outline, but maybe you can use something like this. I have tried this method and the result looks better, as for me. Also, in this case, you can add blur-radius parameter.

/* emulate text outline */

Thanks :)

@palemieux
Copy link
Contributor

Can you provide a test file, current render and preferred render?

@dmkyr20
Copy link
Author

dmkyr20 commented Apr 15, 2020

Sure IMSC_textOutline_issue.zip. The IMSC_textOutine_using_shadows file contains emulation ot the textOutline by myself. Using the IMSC_textOutline_using_textOutline file you can see the current render.

Current:
GitIMSC_issue

Preferred:
GitIMSC

@palemieux
Copy link
Contributor

Thanks. I have seen text outline typically used with white text and surrounded by a small black outline, so we should make sure this new scheme works well in that case.

@palemieux
Copy link
Contributor

@dmkyr20 Does the following capture what you have in mind?

https://codepen.io/palemieux/pen/WNQRqJP

@dkneeland Thoughts on changing tts:textOutline as proposed above?

@dmkyr20
Copy link
Author

dmkyr20 commented Apr 24, 2020

@palemieux Hi, yes. I think it looks better than the current text outline render

@nigelmegitt
Copy link
Contributor

https://codepen.io/palemieux/pen/WNQRqJP

That looks like a worthwhile improvement to me, especially experimenting with changing the background and foreground colour to be the same, e.g. white/yellow/lime/cyan/red foreground on white or black background.

@palemieux
Copy link
Contributor

palemieux commented May 1, 2020

@dmkyr20 See PR at #175. Also deployed at http://sandflow.com/imsc1_1/index.html

@dmkyr20
Copy link
Author

dmkyr20 commented May 4, 2020

@palemieux Hey, It looks great. Thanks) Could I ask one more thing. If I add a blur radius for text-outline the text-outline stops working. Could you fix it?

Text-outline documentation: https://www.w3.org/TR/ttml/#style-attribute-textOutline

@palemieux
Copy link
Contributor

@dmkyr20 Thanks for the feedback.

If I add a blur radius for text-outline the text-outline stops working. Could you fix it?

#textOutline-blurred is prohibited in IMSC.

What is the objective of using blur?

@dmkyr20
Copy link
Author

dmkyr20 commented May 4, 2020

@palemieux Oh, sorry. That's my mistake) Thanks for help)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants