You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since version 1.1.0, generated html for ttml span contains one <span> per character.
For what I understand, textCombine style should be used only in the context of a vertical writing mode.
But it seems that we always go into this part of the code whether we are writing horizontally or not
Wrapping each character in an individual HTML <span> is required to determine end of line locations. This is in turn required for linePadding, rubyReserve, textEmphasis, applyMultiRowAlign and fillLineGap. textCombine actually turns off the wrapping of individual characters since no line break can happen within.
So, until CSS, adds support for the styles above, imscJS will need to continue wrapping characters into individual <span> elements :(
* Merge adjacent spans on the same line that originate from the same ISD element (after line wrapping is performed) (#194, #109)
* Improve fillLineGap with semi-opaque background colors (#200)
Co-authored-by: Robert Bryer <robert.bryer@bbc.co.uk>
Since version 1.1.0, generated html for ttml span contains one
<span>
per character.For what I understand, textCombine style should be used only in the context of a vertical writing mode.
But it seems that we always go into this part of the code whether we are writing horizontally or not
imscJS/src/main/js/html.js
Line 393 in 6039c0a
See ttml file example provided
sub_eng_short.xml.zip
For example
TTML code
<span style="s1">eng : 00:00:00.000</span>
Generated html code
<span style="margin: 0px; color: rgb(255, 255, 0); direction: ltr; font-family: sans-serif; font-size: 46px; font-style: normal; font-weight: normal; text-decoration: none; text-combine-upright: none; unicode-bidi: normal; visibility: visible; white-space: nowrap;"><span>e</span><span>n</span><span>g</span><span> </span><span>:</span><span> </span><span>0</span><span>0</span><span>:</span><span>0</span><span>0</span><span>:</span><span>0</span><span>1</span><span>.</span><span>0</span><span>0</span><span>0</span></span>
The text was updated successfully, but these errors were encountered: