Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Clear error message for duplicated file names #363

Closed
nickp60 opened this issue Nov 13, 2017 · 1 comment
Closed

Feature Request: Clear error message for duplicated file names #363

nickp60 opened this issue Nov 13, 2017 · 1 comment

Comments

@nickp60
Copy link
Contributor

nickp60 commented Nov 13, 2017

Hi,
Just a small request: I had a large dataset that (unknown to me) contained a few .gff files with the same basename. When executing, I kept getting the "Could not extract any protein sequences" error, asking me to check whether or not my files actually had a sequence in them. After renaming the files, the error went away. I may be the only one to have this issue, but would it be difficult to add a earlier error. something to the effect of "error! basenames of gff files must be unique"?

Thanks for writing Roary!

@nickp60 nickp60 changed the title Better error message for duplicated file names Feature Request: Clear error message for duplicated file names Nov 13, 2017
@katrielalex
Copy link

+1 to this feature request. In particular, running Prokka with --outdir foo makes it generate output files of the form foo/PROKKA_MMDDYYYY.gff, so if you directly invoke roary on the results you get this error.

nickp60 added a commit to nickp60/Roary that referenced this issue Dec 14, 2017
andrewjpage added a commit that referenced this issue Dec 20, 2017
Issue #363 add check for duplicate basenames
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants