Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove dependency, add examples #36

Merged
merged 2 commits into from
Mar 6, 2023
Merged

Conversation

runeb
Copy link
Member

@runeb runeb commented Mar 2, 2023

This module was depending on @sanity/client, but only for typescript types. Remove the dependency all together and will instead expect an object with a suitable fetch function passed in.

Also added more examples and updated README

@runeb runeb requested review from snorrees and stipsan March 2, 2023 21:05
Copy link

@snorrees snorrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix!

@runeb runeb merged commit 2a739bd into main Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants