Skip to content

Commit

Permalink
chore(structure): remove the usePrevious hook in useConditionalToast
Browse files Browse the repository at this point in the history
  • Loading branch information
pedrobonamin committed Aug 21, 2024
1 parent e1cecba commit 0c63c49
Showing 1 changed file with 3 additions and 19 deletions.
Original file line number Diff line number Diff line change
@@ -1,13 +1,5 @@
import {type ToastParams, useToast} from '@sanity/ui'
import {useEffect, useRef} from 'react'

function usePrevious<T>(value: T) {
const ref = useRef<T>()
useEffect(() => {
ref.current = value
}, [value])
return ref.current
}
import {useEffect} from 'react'

// https://developer.mozilla.org/en-US/docs/Web/API/setTimeout#maximum_delay_value
const LONG_ENOUGH_BUT_NOT_TOO_LONG = 1000 * 60 * 60 * 24 * 24
Expand All @@ -18,20 +10,12 @@ const LONG_ENOUGH_BUT_NOT_TOO_LONG = 1000 * 60 * 60 * 24 * 24
export function useConditionalToast(params: ToastParams & {id: string; enabled?: boolean}) {
const toast = useToast()

const wasEnabled = usePrevious(params.enabled)
// note1: there's a `duration || 0` in Sanity UI's pushToast(), so make it non-falsey
// note2: cannot use `Infinity` as duration, since it exceeds setTimeout's maximum delay value
useEffect(() => {
if (!wasEnabled && params.enabled) {
if (params.enabled) {
toast.push({...params, duration: LONG_ENOUGH_BUT_NOT_TOO_LONG})
}
if (wasEnabled && !params.enabled) {
toast.push({
...params,
// Note: @sanity/ui fallbacks to the default duration of 4s in case of falsey values
duration: 0.01,
})
}
return () => {
if (params.enabled) {
toast.push({
Expand All @@ -41,5 +25,5 @@ export function useConditionalToast(params: ToastParams & {id: string; enabled?:
})
}
}
}, [params, toast, wasEnabled])
}, [params, toast])
}

0 comments on commit 0c63c49

Please sign in to comment.