-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure search context provider value is memoized #7200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
requested review from
a team and
ninaandal
and removed request for
a team
July 18, 2024 23:30
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
No changes to documentation |
Component Testing Report Updated Jul 31, 2024 8:03 AM (UTC)
|
bjoerge
reviewed
Jul 24, 2024
packages/sanity/src/core/studio/components/navbar/search/components/common/SearchWrapper.tsx
Show resolved
Hide resolved
stipsan
force-pushed
the
ensure-search-provider-state-is-memoized
branch
from
July 29, 2024 08:15
98f26f6
to
3b20496
Compare
stipsan
force-pushed
the
ensure-search-provider-state-is-memoized
branch
from
July 31, 2024 07:44
3b20496
to
a9c9cce
Compare
cngonzalez
pushed a commit
that referenced
this pull request
Aug 20, 2024
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to #7199, read its description for all the deets. The SearchProvider warrants its own PR since it required more work than simply wrapping the context value in a
useMemo
.What to review
Does it make sense?
Testing
If you can click outside the global search and it closes successfully then it works 🎉
Notes for release
N/A