Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure search context provider value is memoized #7200

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

stipsan
Copy link
Member

@stipsan stipsan commented Jul 18, 2024

Description

Relates to #7199, read its description for all the deets. The SearchProvider warrants its own PR since it required more work than simply wrapping the context value in a useMemo.

What to review

Does it make sense?

Testing

If you can click outside the global search and it closes successfully then it works 🎉

Notes for release

N/A

@stipsan stipsan requested review from a team and ninaandal and removed request for a team July 18, 2024 23:30
Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:58am
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:58am
test-compiled-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:58am
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:58am
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2024 7:58am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Jul 31, 2024 7:58am

Copy link
Contributor

No changes to documentation

Copy link
Contributor

github-actions bot commented Jul 19, 2024

Component Testing Report Updated Jul 31, 2024 8:03 AM (UTC)

File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 45s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 9s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 36s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 10s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ✅ Passed (Inspect) 3m 0s 0 0 0
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 43s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 1m 41s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 14s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 8s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 26s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 17s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ❌ Failed (Inspect) 1m 33s 19 0 2
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 1m 46s 30 0 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 19s 3 0 0

@stipsan stipsan enabled auto-merge July 23, 2024 11:42
@ninaandal ninaandal requested review from bjoerge and removed request for ninaandal July 24, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants