Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #15 allow punctuation marks #17

Merged
merged 1 commit into from
Jan 5, 2021
Merged

resolves #15 allow punctuation marks #17

merged 1 commit into from
Jan 5, 2021

Conversation

ggrossetie
Copy link
Contributor

resolves #15

@ggrossetie ggrossetie force-pushed the issue-15-punctuation-marks branch from 24eec09 to d73221e Compare January 4, 2021 13:17
sapegin
sapegin reviewed Jan 4, 2021
View reviewed changes
Copy link
Owner

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've left one minor comment.

index.js Outdated Show resolved Hide resolved
@ggrossetie ggrossetie force-pushed the issue-15-punctuation-marks branch from d73221e to b171651 Compare January 4, 2021 17:41
@sapegin sapegin merged commit 4ebeaf3 into sapegin:master Jan 5, 2021
@sapegin
Copy link
Owner

sapegin commented Jan 5, 2021

🎉 This PR is included in version 2.0.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ggrossetie ggrossetie deleted the issue-15-punctuation-marks branch January 5, 2021 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapegin sapegin sapegin left review comments

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The positive look ahead should include punctuation marks (, ! ? : ;)
2 participants
@ggrossetie @sapegin