Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust Edition 2021 #263

Merged
merged 6 commits into from
Jan 4, 2024
Merged

Conversation

cryptoquick
Copy link
Contributor

Followed the instructions here:
https://doc.rust-lang.org/edition-guide/editions/transitioning-an-existing-project-to-a-new-edition.html

Resolves this warning when trying to run the example:

warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions

Also, forgive the TOML autoformat noise, I didn't realize it would run when doing a global find-and-replace, but it did. At least it looks neater?


To run plugin examples, you must first have zig and wasm-pack installed.

Then run: `CC="zig cc" wasm-pack build`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure that Zig is required, but doesn't seem like the worst idea to use it as CC. Can you say more on why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was something I was told... I can try validating that assumption

@JeremyRubin JeremyRubin merged commit 9fcc1e9 into sapio-lang:master Jan 4, 2024
@cryptoquick cryptoquick deleted the HB/2021 branch January 4, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants