Test PR to see PR template and bot comments in action #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 0bc1029; changes) is ready! 🎉 |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 11, 2024
Previously, the documentation comment on GitHub would be removed and then recreated whenever there is a change to a PR which creates notification emails and to some feels like it's polluting their GitHub inbox. Here, we change this behavior so that only the initial build of the documentation causes such a notification. Further updates to the documentation do update the links in the comment but do not trigger a notification. This is meant as an alternative to sagemath#37387. See sagemath#37739 for futher ideas about a smarter behavior here. An actual preview of the result can be seen here: saraedum#2 Note that the links on that PR do not work because my fork does not have netlify credentials configured. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes; this is fairly hard to test automatically. I'll test this manually if there is interest in merging this. - [x] I have updated the documentation accordingly; kind of, I updated the PR checklist. URL: sagemath#37740 Reported by: Julian Rüth Reviewer(s): Dima Pasechnik, Julian Rüth, Kwankyu Lee
mkoeppe
pushed a commit
that referenced
this pull request
Aug 3, 2024
Remove excessive blank lines around INPUT, OUTPUT, EXAMPLES, and before docstring ending """. (#2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies