[v6] Check git tree on CI (Azure#637)

* initial tree check

* add npm script and check tree on ci

* Add missing changes from last commit

.scripts/ci.yml

@@ -17,10 +17,12 @@ steps:
 
 - script: |
     npm run test
+    npm run check:tree
   displayName: 'Run Tests'
 
 - script: |
     npm run smoke-test
+    npm run check:tree
   displayName: 'Run Smoke Tests'
 
 - script: |

package.json

@@ -4,6 +4,7 @@
     "private": true,
     "scripts": {
         "build": "tsc -p .",
+        "check:tree": "ts-node ./test/utils/check-clean-tree.ts",
         "start": "node ./dist/src/main.js",
         "test": "npm-run-all unit-test integration-test",
         "unit-test": "mocha -r ts-node/register './test/unit/**/*spec.ts'",

test/integration/generated/mediaTypesV3Lro/src/mediaTypesV3LROClient.ts

@@ -224,7 +224,7 @@ const send$binaryOperationSpec: coreHttp.OperationSpec = {
   httpMethod: "POST",
   responses: { 204: {}, 400: {} },
   requestBody: Parameters.data,
-  queryParameters: [Parameters.excluded1],
+  queryParameters: [Parameters.excluded],
   urlParameters: [Parameters.$host, Parameters.thing],
   headerParameters: [Parameters.contentType],
   serializer
@@ -234,7 +234,7 @@ const send$textOperationSpec: coreHttp.OperationSpec = {
   httpMethod: "POST",
   responses: { 204: {}, 400: {} },
   requestBody: Parameters.data1,
-  queryParameters: [Parameters.excluded1],
+  queryParameters: [Parameters.excluded],
   urlParameters: [Parameters.$host, Parameters.thing],
   headerParameters: [Parameters.contentType1],
   serializer

test/integration/generated/mediaTypesV3Lro/src/models/parameters.ts

@@ -87,14 +87,3 @@ export const thing: coreHttp.OperationURLParameter = {
     }
   }
 };
-
-export const excluded1: coreHttp.OperationQueryParameter = {
-  parameterPath: ["options", "excluded"],
-  mapper: {
-    serializedName: "excluded",
-    type: {
-      name: "Sequence",
-      element: { type: { name: "String" } }
-    }
-  }
-};

test/utils/check-clean-tree.ts

@@ -0,0 +1,55 @@
+import { spawn, ChildProcess } from "child_process";
+
+const onExit = (childProcess: ChildProcess): Promise<string[]> => {
+  let messages: string[] = [];
+  return new Promise((resolve, reject) => {
+    if (childProcess.stdout) {
+      childProcess.stdout.on("data", message => messages.push(message));
+    }
+    childProcess.once("exit", (code: number, signal: string) => {
+      if (code === 0) {
+        resolve(messages);
+      }
+      reject(new Error(`Exit with code: ${code}`));
+    });
+
+    childProcess.once("error", (error: Error) => {
+      reject(error);
+    });
+  });
+};
+
+async function check_tree() {
+  await onExit(
+    spawn("git", ["add", "-A"], {
+      stdio: [process.stdin, process.stdout, process.stderr]
+    })
+  );
+
+  // If there is any output from this command it means that
+  // there are non committed changes so we need to handle
+  // stout
+  const messages = await onExit(
+    spawn("git", ["diff", "--staged", "--compact-summary"])
+  );
+
+  if (messages.length !== 0) {
+    // Once we have verified that there are non committed changes
+    // run git diff again, this time forwarding the stout to present
+    // a readable hint to the user
+    await onExit(
+      spawn("git", ["diff", "--staged", "--compact-summary"], {
+        stdio: [process.stdin, process.stdout, process.stderr]
+      })
+    );
+
+    throw new Error(
+      "Git tree is dirty, regenerate all test swaggers and make sure that there are no un-intended changes"
+    );
+  }
+}
+
+check_tree().catch(error => {
+  console.error(error);
+  process.exit(-1);
+});