forked from Expensify/App
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new #1
Merged
saranshbalyan-1234
merged 1,968 commits into
stop-magiccode-instant-submit-onchange
from
main
Oct 17, 2023
Merged
new #1
saranshbalyan-1234
merged 1,968 commits into
stop-magiccode-instant-submit-onchange
from
main
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tate-view-and-add-bank-accounts-plus-wallet-tile feat(Wallet): add empty state and redesign wallet page
…tions-ReportPreviewEReceipt [Wave 8- ECard Transactions] Update `ReportPreview` styling (`ReportActionItemImages`)
…entRect Use getBoundingClientRect as a fallback
Show eReceipts for distance requests
Trim the value when going back on connect bank account
…yle/styles-refactor
…sage-displays-briefly-after-reopening-the-2FA-step-2-page Fix Error message displays briefly after reopening the 2FA step 2 page
Signed-off-by: Yauheni Pasiukevich <pasyukevich@live.com>
…usher fix: 404 authenticate pusher api call
…space [Expensify#16935] Workspace creation with Policy Draft info
[CP Staging] Revert PR 28278
…compatible Make Bun compatible
Workspace admin checkbox
…picker-refactor Refactor DatePicker component for ios
…ontent_rights_has_rights Add `content_rights_has_rights` to Fastlane's submission information
Update Google-Apps-SSO.md
…arifyingTranslation [NO QA] Add comment clarifying "Chats" translation
…tial-display exclude reports in LHN that has no report type
…on-button-in-address-search Added location button in address search
…ckForMissedTag Revert "[NoQA] Temporarily update the getPreviousVeriosn to skip over missing tag"
…t-translate-copy-to-clipboard-text-for-requested Fix: Chat - Pasted text reflects Full Display name
Fix shouldUseFullTitle in ReportDetailsPage
…ion-between-ats fix: Chat - App closes mention suggestions when cursor is between double @
Allow platinum wallets to transact
…ignInRedirect-lib [No QA] [TS migration] Migrate 'SignInRedirect.js' lib to TypeScript
…6161/hoverable-class-to-functional Refactor Hoverable component into functional
saranshbalyan-1234
pushed a commit
that referenced
this pull request
Oct 19, 2023
…s methods Signed-off-by: Ashutosh Khanduala <ashu.khanduala@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop