Remove SSH connection test since Gitlab Runner provides this feature already #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…already Gitlab Runner already provides this feature with the config option runners.autoscaler.instance_ready_command. Let's remove it to have fewer code and faster connections. See https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-runnersautoscaler-section
vooon
approved these changes
Dec 13, 2024
|
Yes, you've implemented it before Gitlab Runner had that feature :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gitlab Runner already provides this feature with the config option runners.autoscaler.instance_ready_command. Let's remove it to have fewer code and faster connections.
See https://docs.gitlab.com/runner/configuration/advanced-configuration.html#the-runnersautoscaler-section