Skip to content

Commit

Permalink
Fix the default separator for new SassArgumentList in the JS API (#1580)
Browse files Browse the repository at this point in the history
  • Loading branch information
nex3 authored Dec 31, 2021
1 parent a32000e commit 169178a
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 4 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
## 1.45.2

### JS API

* **Potentially breaking bug fix:** Change the default value of the `separator`
parameter for `new SassArgumentList()` to `','` rather than `null`. This
matches the API specification.

## 1.45.1

* **Potentially breaking bug fix:** Properly parse custom properties in
Expand Down
3 changes: 2 additions & 1 deletion lib/src/node/value/argument_list.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import '../utils.dart';
/// The JavaScript `SassArgumentList` class.
final JSClass argumentListClass = () {
var jsClass = createJSClass('sass.SassArgumentList',
(Object self, Object contents, Object keywords, [String? separator]) {
(Object self, Object contents, Object keywords,
[String? separator = ',']) {
return SassArgumentList(
jsToDartList(contents).cast<Value>(),
(isImmutableMap(keywords)
Expand Down
4 changes: 4 additions & 0 deletions pkg/sass_api/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.0-beta.25

* No user-visible changes.

## 1.0.0-beta.24

* No user-visible changes.
Expand Down
4 changes: 2 additions & 2 deletions pkg/sass_api/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,15 @@ name: sass_api
# Note: Every time we add a new Sass AST node, we need to bump the *major*
# version because it's a breaking change for anyone who's implementing the
# visitor interface(s).
version: 1.0.0-beta.24
version: 1.0.0-beta.25
description: Additional APIs for Dart Sass.
homepage: https://github.com/sass/dart-sass

environment:
sdk: '>=2.12.0 <3.0.0'

dependencies:
sass: 1.45.1
sass: 1.45.2

dependency_overrides:
sass: {path: ../..}
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sass
version: 1.45.1
version: 1.45.2
description: A Sass implementation in Dart.
homepage: https://github.com/sass/dart-sass

Expand Down

0 comments on commit 169178a

Please sign in to comment.