Make meta.apply() an AsyncBuiltInCallable (#2152)

Closes #2151
sass · Dec 28, 2023 · f3c7be5 · f3c7be5
1 parent 1fc740d
commit f3c7be5
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,6 +11,8 @@
 
 * Provide official releases for musl LibC and for Android.
 
+* Don't crash when running `meta.apply()` in asynchronous mode.
+
 ### JS API
 
 * Fix a bug where certain exceptions could produce `SourceSpan`s that didn't

diff --git a/lib/src/visitor/async_evaluate.dart b/lib/src/visitor/async_evaluate.dart
@@ -545,7 +545,8 @@ final class _EvaluateVisitor
             namesInErrors: true);
         _assertConfigurationIsEmpty(configuration, nameInError: true);
       }, url: "sass:meta"),
-      BuiltInCallable.mixin("apply", r"$mixin, $args...", (arguments) async {
+      AsyncBuiltInCallable.mixin("apply", r"$mixin, $args...",
+          (arguments) async {
         var mixin = arguments[0];
         var args = arguments[1] as SassArgumentList;
 

diff --git a/lib/src/visitor/evaluate.dart b/lib/src/visitor/evaluate.dart
@@ -5,7 +5,7 @@
 // DO NOT EDIT. This file was generated from async_evaluate.dart.
 // See tool/grind/synchronize.dart for details.
 //
-// Checksum: 58ef9912c6a9d9cfe9c3f5d991f625ab1a627e7a
+// Checksum: 71dcf1747eb45036d3c1b5b57bd0cd5dbe6b8e14
 //
 // ignore_for_file: unused_import
 

diff --git a/pkg/sass_api/CHANGELOG.md b/pkg/sass_api/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 9.2.6
+
+* No user-visible changes.
+
 ## 9.2.5
 
 * No user-visible changes.

diff --git a/pkg/sass_api/pubspec.yaml b/pkg/sass_api/pubspec.yaml
@@ -2,15 +2,15 @@ name: sass_api
 # Note: Every time we add a new Sass AST node, we need to bump the *major*
 # version because it's a breaking change for anyone who's implementing the
 # visitor interface(s).
-version: 9.2.5
+version: 9.2.6
 description: Additional APIs for Dart Sass.
 homepage: https://github.com/sass/dart-sass
 
 environment:
   sdk: ">=3.0.0 <4.0.0"
 
 dependencies:
-  sass: 1.69.5
+  sass: 1.69.6
 
 dev_dependencies:
   dartdoc: ^6.0.0

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: sass
-version: 1.69.6-dev
+version: 1.69.6
 description: A Sass implementation in Dart.
 homepage: https://github.com/sass/dart-sass