-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent formatting of degenerate numbers with units #2070
Comments
Other implementations don't have to match the same error output as Dart Sass; since errors are purely cosmetic, you can feel free to have your own formatting as long as you emit errors under the same circumstances. |
That is true, thanks. But by trying to make the errors exactly the same in rsass as in dart sass, I make it easier for myself to keep track of which things are handled correctly and what remains to be done. Also, I think avoiding "Infinitypx" and making errors consistent with the css formatting would be an improvement for dart sass as well. So I agree with @jathak that this is a bug, but only a cosmetic one. |
In
spec/values/numbers/degenerate.hrx
there is tests for degenerate numbers both in css output and in error messages. The css output formats the numbes like e.g.... while the error messages looks like:
Could the expected error messages be updated to have the same formatting as the css output (in this case
calc(-infinity * 1px*em)
with lower-case i and multiplied by one for the unit) ?It would make other implementations (like rsass) simpler, and my guess is that it should simplify dart sass as well.
The text was updated successfully, but these errors were encountered: