Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--silence-deprecation doesn't work on the CLI #2244

Closed
mwojslaw opened this issue May 15, 2024 · 1 comment · Fixed by #2246
Closed

--silence-deprecation doesn't work on the CLI #2244

mwojslaw opened this issue May 15, 2024 · 1 comment · Fixed by #2246
Assignees
Labels

Comments

@mwojslaw
Copy link

Hi, is it possible to leave invalid CSS after running sass compilation? Sass cli command is only part of our styling pipe, unfortunately one that have to be process at the beginning. We're making use of "deep selector" (vuejs term) which looks like this "& >>> li", and is processed by different software. When running sass cli this part of css is cut with message: "The selector "& > > > li" is invalid CSS. It will be omitted from the generated CSS.
This will be an error in Dart Sass 2.0.0".

Can we somehow take this problem? I tried to use --silence-deprecation=bogus-combinators but without success.

@nex3
Copy link
Contributor

nex3 commented May 15, 2024

No. This will be a syntax error in Dart Sass 2.0.0, which means that there won't be a way for us to even represent it internally. In fact, one of the major reasons we're deprecating this behavior is because the current internal representation of invalid combinators adds major complications to Sass's selector logic.

I strongly recommend filing an issue against Vue to provide an alternative, CSS-compatible syntax for this. For example, Angular uses ::ng-deep for something similar.

I tried to use --silence-deprecation=bogus-combinators but without success.

This is a bug. I'll work on a fix.

@nex3 nex3 changed the title Leave invalid CSS after compilation option --silence-deprecation doesn't work on the CLI May 15, 2024
@nex3 nex3 self-assigned this May 15, 2024
@nex3 nex3 added the bug label May 15, 2024
nex3 added a commit that referenced this issue May 15, 2024
nex3 added a commit that referenced this issue May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants