Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

invert() with $weight: 50% is wrong #704

Closed
nex3 opened this issue May 30, 2019 · 0 comments
Closed

invert() with $weight: 50% is wrong #704

nex3 opened this issue May 30, 2019 · 0 comments
Labels

Comments

@nex3
Copy link
Contributor

nex3 commented May 30, 2019

Dart Sass's definition of the invert() function has the $weight parameter default to 50%, which is wrong (Ruby Sass defaults to 100%). The only reason this doesn't cause huge problems is that it also has a special case to avoid the call to mix() when $weight is 50%, but this means that if $weight is explicitly passed as 50% it gives the wrong result.

@nex3 nex3 added the bug label May 30, 2019
nex3 added a commit to sass/sass-spec that referenced this issue Jul 3, 2019
nex3 added a commit to sass/sass-spec that referenced this issue Jul 3, 2019
nex3 added a commit to sass/sass-spec that referenced this issue Jul 3, 2019
@nex3 nex3 closed this as completed in d5adb46 Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant