Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let inspect() print nested, empty, bracketed lists. #1547

Merged
merged 5 commits into from
Dec 10, 2021
Merged

Let inspect() print nested, empty, bracketed lists. #1547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9cb976e
Static analysis.
Awjin Nov 5, 2021
406dcee
Properly seralize empty, bracketed lists.
Awjin Nov 5, 2021
d48e744
Code review.
Awjin Dec 3, 2021
cc63989
Bump sass_api pubspec.
Awjin Dec 4, 2021
e8d0881
Merge branch 'main' into nested-empty-list
nex3 Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## 1.45.1

* **Potentially breaking bug fix:** Fix a bug where `inspect()` was not
properly printing nested, empty, bracketed lists.

## 1.45.0

### JS API
Expand Down
3 changes: 2 additions & 1 deletion lib/src/value/list.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ class SassList extends Value {

/// @nodoc
@internal
bool get isBlank => asList.every((element) => element.isBlank);
bool get isBlank =>
!hasBrackets && asList.every((element) => element.isBlank);

List<Value> get asList => _contents;

Expand Down
2 changes: 1 addition & 1 deletion pkg/sass_api/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ environment:
sdk: '>=2.12.0 <3.0.0'

dependencies:
sass: 1.45.0
sass: 1.45.1

dependency_overrides:
sass: {path: ../..}
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: sass
version: 1.45.0
version: 1.45.1-dev
Awjin marked this conversation as resolved.
Show resolved Hide resolved
description: A Sass implementation in Dart.
homepage: https://github.com/sass/dart-sass

Expand Down