Allow adjacent forward slashes in plain CSS expressions #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathak
approved these changes
Mar 12, 2024
| @@ -32,7 +32,9 @@ class CssParser extends ScssParser { | |||
|
|
|||
| CssParser(super.contents, {super.url, super.logger}); | |||
|
|
|||
| void silentComment() { | |||
| bool silentComment() { | |||
There was a problem hiding this comment.
Is there a reason why we allow silent comments at all when parsing plain CSS?
There was a problem hiding this comment.
We don't, but we do want to throw an explicit error when we encounter them. This is particularly true because historically LibSass parsed .css files as SCSS and some frameworks took advantage of this, so there are definitely real world cases where the user needs a better error than whatever parsing failure they'd get in plain CSS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3797
See sass/sass-spec#1961