Add a per-importer cache for loads that aren't cacheable en masse #2219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by comments on #2215
nex3
force-pushed
the
per-importer-cache
branch
from
015856c
to
7f4c817
Compare
ntkme
reviewed
Apr 12, 2024
Goodwine
approved these changes
Apr 12, 2024
| @@ -181,17 +168,34 @@ final class AsyncImportCache { | |||
| // `canonicalize()` calls we've attempted are cacheable. Only if they are do | |||
| // we store the result in the cache. | |||
| var cacheable = true; | |||
| for (var importer in _importers) { | |||
| for (var i = 0; i < _importers.length; i++) { | |||
| var importer = _importers[i]; | |||
There was a problem hiding this comment.
There should be a check around here for the presence of _perImporterCanonicalizeCache, no?
Otherwise _canonicalize gets executed for all the importers previous to the one that returned a non-null and non-cacheable result
There was a problem hiding this comment.
Yeah, actually checking the cache is an important part of a caching scheme 😅
Goodwine
requested changes
Apr 12, 2024
Goodwine
approved these changes
Apr 12, 2024
|
@ntkme Can you take another look at this? |
ntkme
approved these changes
Apr 18, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by comments on #2215