Parse silent comments in _interpolatedDeclarationValue()
#2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
force-pushed
the
silent-comment-everywhere
branch
from
280de8c
to
18cd524
Compare
Goodwine
approved these changes
Jun 19, 2024
| @@ -133,7 +133,8 @@ class Parser { | |||
| whitespace(); | |||
| } | |||
|
|
|||
| /// Consumes and ignores a silent (Sass-style) comment. | |||
| /// Consumes and ignores a single silent (Sass-style) comment, not including | |||
| /// the trailing newline. | |||
There was a problem hiding this comment.
"not including the trailing newline" makes me wonder about what happens when there are consecutive lines with silent comments, but otherwise LGTM
There was a problem hiding this comment.
This function will only consume one of them, but whitespace() will consume them all and the whitespace.
stof
reviewed
Aug 15, 2024
| wroteNewline = false; | ||
| } | ||
|
|
||
| case $slash when silentComments && scanner.peekChar(1) == $slash: | ||
| buffer.write(rawText(loudComment)); |
There was a problem hiding this comment.
should this really parse a loud comment when finding // ? Or is this dead code because of going through the previous case all the time ?
There was a problem hiding this comment.
You're right that it's incorrect and also that it's dead code. I'll send out a PR to remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2263
See sass/sass-spec#2000