Add module-variables() and module-functions() #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this travis run need attention? |
|
It's failing because of the issue you pointed out in the specs. I've restarted it, so it should work now. |
nshahan
approved these changes
Jun 18, 2019
|
|
||
| return SassMap({ | ||
| for (var entry in module.variables.entries) | ||
| SassString(entry.key): entry.value |
There was a problem hiding this comment.
Any danger of exposing something you don't want to by returning this Value through the map without reboxing it in some way?
There was a problem hiding this comment.
No, Values are intentionally only ever normal Sass values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #554
See sass/sass-spec#1403