Add support for "@use with" #728
Conversation
There was a problem hiding this comment.
My only comments are regarding the wording of the error messages. They feel somewhat vague and lacking the details of the specific symbols. Maybe you want to rely on the user filling in the details from the source span that is printed but I feel like they are more actionable when they are more specific. WDYT?
There was a problem hiding this comment.
I generally avoid explicitly writing identifiers that are implicated in errors because, as you say, they're already present in the source spans. I find repeating names multiple times in errors to be more confusing and cluttered than helpful. I'm not sure what you mean by including the identifiers being "more actionable"—can you elaborate?
There was a problem hiding this comment.
Sounds good. If you have a consistent pattern for the messages with accompanying source spans then I'm ok with sticking with that. I think I respond better to messages that contain the symbols/names that are causing the problem but I recognize that is subjective. The new source span format is very helpful in drawing attention to where the problem is.
|
Tests are failing due to an analyzer deprecation that's fixed in #735. I'll have to merge that into feature.use and then merge feature.use into this to fix the issue, but you should be able to review in the meantime. |
See sass/sass-spec#1412