Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in silent comment error message #761

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Jul 14, 2019

@nex3
Copy link
Contributor

nex3 commented Jul 15, 2019

Thanks for the fix! Can you also update the newly-failing spec?

@mgreter
Copy link
Contributor Author

mgreter commented Jul 15, 2019

There you go sass/sass-spec#1432

@nex3
Copy link
Contributor

nex3 commented Jul 15, 2019

Thanks! For future reference, when making changes across both Dart Sass and sass-spec, please link the PRs as described in step 4 of https://github.com/sass/sass/blob/master/CONTRIBUTING.md so that the Travis tests run properly. I've done it for you for this PR though!

@nex3 nex3 merged commit d91e758 into sass:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants