-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raw CSS @imports no longer work #245
Comments
Sorry, I was being dumb above. Importing css files is not working since the release of v14.3. As always you can do a css "import" eg. reference a separate file by using I guess this means libass-python need to support Part of the problem is that the 3.5.3 release notes are confusing
For me at least it's just downright failing rather than giving a deprecation |
CC @xzyfer -- this seems to be a regression from
|
I've made an upstream issue: sass/libsass#2636 |
This was done in sass/libsass#1963. See sass/libsass@e690924 and the PR which preceded it sass/libsass#1964 this was their intended behaviour. I've provided a fix in #246 |
Apologies this breaking change unintentionally landed in 3.5.3 instead of 3.6.0. We plan to roll forward with the breaking change, and have update the release notes accordingly. |
See https://github.com/sass/libsass/releases/tag/3.5.3
This changed the current behaviour of libass-python such that importing raw css files without thesee below.css
extension no longer works. Was this intentional? Might have been useful to include this in the changelog.I'm not seeing the deprecation warnings noted above. Maybe I'm not logging warnings or something?see belowcss
files after 3.6 is released, will this require any changes to libsass-python? Eg. to supportsass_option_push_import_extension
The text was updated successfully, but these errors were encountered: