Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mix() color arguments have the wrong names #2894

Closed
nex3 opened this issue May 28, 2019 · 0 comments · Fixed by #2934
Closed

mix() color arguments have the wrong names #2894

nex3 opened this issue May 28, 2019 · 0 comments · Fixed by #2934
Labels
Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem

Comments

@nex3
Copy link
Contributor

nex3 commented May 28, 2019

Way back in 2013, in sass/ruby-sass@603cbf4, Ruby Sass updated the argument names for mix() to be $color1 and $color2 rather than $color-1 and $color-2, for consistency with other core library functions. It looks like LibSass never did the corresponding update, though, and still has the old argument names.
@nex3 nex3 added the Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem label Jun 3, 2019
nschonni pushed a commit to nschonni/libsass that referenced this issue Jun 28, 2019
fix(mix): Align argurment names to color1/color2
d45d1ba 
Closes sass#2894
@nschonni nschonni mentioned this issue Jun 28, 2019
Merged
nschonni added a commit to nschonni/libsass that referenced this issue Jun 28, 2019
@nschonni
fix(mix): Align argurment names to color1/color2
3844174 
Closes sass#2894
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Compatibility - P3 Minorly important for compatibility with the Sass spec and ecosystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mix): Align argurment names to color1/color2 nschonni/libsass
1 participant
@nex3