-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement missing error checks #1848
Conversation
0e9279c
to
85e1316
Compare
85e1316
to
5a7abc3
Compare
db20ea1
to
19b24a7
Compare
Will merge this as soon as ci is 💚 If any of these error checks regress we can still just uncomment them. I hope we have gathered enough specs to cover pretty much all cases, although I'm not to sure about At_Root and Media_Blocks. But it should also be quite easy to adjust the conditions, since we now can query the parent scope type in parser. I also added a few of my own spec tests to cover the main use cases I could come up with. |
Implement missing error checks
Spec for #1670 activated in sass/sass-spec#684 |
Spec for #1675 activated in sass/sass-spec#685 |
Spec for #871 activated in sass/sass-spec#686 |
Remaining spec for #1653 activated in sass/sass-spec#687 |
Spec for #1550 activated in sass/sass-spec#688 |
Should pass specs sass/sass-spec#680
One minor issue not on par with ruby sass, but that will change once we switch sass specs to 3.4.20.