Newlines: Parse \f and normalize in comments #2849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glebm
force-pushed
the
newlines
branch
3 times, most recently
from
b1710cb
to
c38347b
Compare
glebm
added a commit
to glebm/sass-spec
that referenced
this pull request
Mar 25, 2019
glebm
added a commit
to glebm/sass-spec
that referenced
this pull request
Mar 25, 2019
Also: 1. Moves the `normalize*` functions and `rtrim` to a separate object file, so that they can be unit tested quickly and easily. 2. Changes `string_to_output` to also replace `\r\n`, fixing Windows tests. 3. Improves other `normalize_*` functions and adds tests. Refs sass#2843 sass-spec PRs: 1. Bug fixes to make it run: sass/sass-spec#1365 2. Enabling the newly passing tests: sass/sass-spec#1366
|
Thank you for fixing the Windows failures |
glebm
added a commit
to sass/sass-spec
that referenced
this pull request
Apr 5, 2019
glebm
added a commit
to sass/sass-spec
that referenced
this pull request
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
normalize*functions andrtrimto a separate object file,so that they can be unit tested quickly and easily.
string_to_outputto also replace\r\n, fixing Windows tests.normalize_*functions and adds tests.Fixes #2843
sass-spec PRs: