Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add support for Node 0.12 and node-sass 2.0. Fixes #23 #24

Merged
merged 2 commits into from
Feb 14, 2015
Merged

🐛 Add support for Node 0.12 and node-sass 2.0. Fixes #23 #24

merged 2 commits into from
Feb 14, 2015

Conversation

jerone
Copy link
Contributor

@jerone jerone commented Feb 14, 2015

This PR adds support for Node 0.12 and node-sass 2.0.1.

Tests: ✅

Fixes: #23

Ref: sass/node-sass#656

PR-ready: :shipit:

@am11
Copy link
Collaborator

am11 commented Feb 14, 2015

Thank you! 👍 ⚡

Could you please also change .travis.yml to use 0.12 here (overwriting 0.11) in a separate commit? 0.11 was unstable branch which is superseded by node.js v0.12.

@jerone
Copy link
Contributor Author

jerone commented Feb 14, 2015

@am11 commented on 14 feb. 2015 22:52 CET:

Thank you!

Could you please also change .travis.yml to use 0.12 here (overwriting 0.11) in a separate commit? 0.11 was unstable branch which is superseded by node.js v0.12.

Just noticed that node-sass used version 0.10 & 0.12 and pushed a new commit same time as you commented 😄

@am11
Copy link
Collaborator

am11 commented Feb 14, 2015

Wow coincidence!! 😄

Thanks! 🎉

am11 added a commit that referenced this pull request Feb 14, 2015
🐛 Add support for Node 0.12 and node-sass 2.0. Fixes #23
@am11 am11 merged commit 8b6621c into sass:master Feb 14, 2015
@jerone
Copy link
Contributor Author

jerone commented Feb 14, 2015

@am11 commented on 14 feb. 2015 23:00 CET:

Wow coincidence!!

Thanks!

Great minds think alike :)
Thank for merging 🎆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to support node-sass ^2.0.0 and Node 0.12
2 participants