Regression: incorrect line numbers in source maps

[naartjie]

I think I've found a regression which shows incorrect line numbers. It happened somewhere between v1.0.3 and v1.1.0.

I tried to track it down a bit further, and it looks like it broke when libsass was upgraded to v3.0.1, so it should probably be reported upstream, but I don't want to make a noise there yet, until I'm sure.

What is the proper way to submit a test case? Is it in the sass-spec project? I'd like to investigate this further, but I just need some pointers how to go about this.

[am11]

I just need some pointers how to go about this.

I think you are too late to the part, see: sass/libsass#324.

As a matter of fact, libsass was never producing correct source-maps.

Also see sass/libsass#603.

but I don't want to make a noise there yet, until I'm sure.

If the bug belongs to libsass, then then bug belongs to libsass. You can just come clean about it in their issue tracker.

BTW, node-sass issue tracker is not a backdoor to libsass noise room. 😉

[naartjie]

@am11

I am a node-sass end user so this is my point of entry for reporting any issues I encounter, especially since I am new to libsass. It might seem obvious to a non-newbie, but the propaganda around libsass doesn't exactly say "source maps don't work a 100% yet".

My point was that I was logging an issue for a regression, i.e. it was working (at least for my use case), in an earlier version, and if you're a custodian on any of the sass family of projects you should care about which commit introduced this problem, which BTW was this one, and I will be sure to log it there, now that I know it's exact source.

[booleanbetrayal]

👍

[naartjie]

BTW logged sass/libsass/issues/720