Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

RFC: Binary Coverage Matrix #655

Closed
am11 opened this issue Feb 9, 2015 · 24 comments
Closed

RFC: Binary Coverage Matrix #655

am11 opened this issue Feb 9, 2015 · 24 comments
Labels
Discussion - Proposal npm build

Comments

@am11
Copy link
Contributor

am11 commented Feb 9, 2015

As @kkoopa mentioned at #627 (comment):

A module must be rebuilt whenever NODE_MODULE_VERSION changes. It changed from joyent/node 0.10 -> joyent/node 0.11, from joyent/node 0.11 -> iojs/io.js 1.0, and atom/atom-shell has its own fork going with yet another NODE_MODULE_VERSION.

we need to confine a binary coverage matrix for the most used versions of runtimes (related: #602 (comment)).

Updated:

The current version of node-sass is v2.0.0-beta v2.0.1 and the distributable binary availability of node-sass is given below:

Availability Runtime Version
NODE_MODULE_VERSION		 Platform Architecture
atom-shell 0.21 Linux ia32
atom-shell 0.21 Linux x64
atom-shell 0.21 Mac x64
atom-shell 0.21 Windows ia32
atom-shell 0.21 Windows x64
io.js 1.2 FreeBSD ia32
io.js 1.2 FreeBSD x64
x io.js 1.2 Linux ia32
x io.js 1.2 Linux x64
x io.js 1.2 Mac x64
io.js 1.2 Solaris ia32
io.js 1.2 Solaris x64
x io.js 1.2 Windows ia32
x io.js 1.2 Windows x64
node.js 0.12 FreeBSD ia32
node.js 0.12 FreeBSD x64
x node.js 0.12 Linux ia32
x node.js 0.12 Linux x64
x node.js 0.12 Mac x64
node.js 0.12 Solaris ia32
node.js 0.12 Solaris x64
x node.js 0.12 Windows ia32
x node.js 0.12 Windows x64
node.js 0.10 FreeBSD ia32
node.js 0.10 FreeBSD x64
x node.js 0.10 Linux ia32
x node.js 0.10 Linux x64
x node.js 0.10 Mac x64
node.js 0.10 Solaris ia32
node.js 0.10 Solaris x64
x node.js 0.10 Windows ia32
x node.js 0.10 Windows x64

Note 1: atom-shell does not support FreeBSD and Solaris?
Note 2: This matrix will eventually be added to wiki and we will keep the coverage matrix up to date for the current version of node-sass.
This was referenced Feb 9, 2015
Closed
Closed
Closed
@xzyfer
Copy link
Contributor

xzyfer commented Feb 9, 2015

@am11 will we need to change the install script and node-sass-binaries to handle the different combinations?

i.e. will node 0.10.x binaries work with node 0.12.x and atom 1.x etc...

@am11 am11 mentioned this issue Feb 9, 2015
Closed
@am11
Copy link
Contributor Author

am11 commented Feb 9, 2015

@xzyfer Yes. It would probably be something like: linux-x64-node-0.10.

@Turbo87
Copy link

Turbo87 commented Feb 9, 2015

@am11 wouldn't it be better to put the matrix into the https://github.com/sass/node-sass-binaries README instead of the wiki? that way it would it could always reflect the current state of the repo, you get a history for free and linking to it isn't much harder than linking to the wiki.

@am11
Copy link
Contributor Author

am11 commented Feb 9, 2015

@Turbo87, I think it would make more sense to add it to node-sass-binaries repo's README and a reference in node-sass' README.

In node-sass' README, we do not want to deliver the message as if it is some kind of set in stone limitation. User can manually build binaries on other platforms with various versions of runtimes. This (incomplete) matrix is only showing the binaries which we might be distributing OOTB.

@Turbo87
Copy link

Turbo87 commented Feb 9, 2015

@am11 I know that, and I don't think it will be controversial if you put it exactly like that in the README next to the matrix too.

@Martii
Copy link

Martii commented Feb 9, 2015

some kind of set in stone limitation.

Matrices are usually just denoting what's currently supported and not always set in stone. Anyone familiar with node packages knows that things change. Our project for example uses exact semver releases.

User can manually build binaries on other platforms with various versions of runtimes.

Our node host provider won't allow this as I previously mentioned over at the node-sass-binaries repo issues... our provider just happens to be joyent maintained as well.

As a potential further solution for displaying the matrices there is always GH io pages. That could be a common place to bring multiple repos together.

This was referenced Feb 10, 2015
Merged
Merged
@am11
Copy link
Contributor Author

am11 commented Feb 10, 2015

Super awesome @xzyfer for Mac binaries! 👍

Keep them coming! 😎

I am trying to figure out a sanest way to differentiate between runtimes, which is yet to be discovered (see nodejs/node-gyp#564 (comment)). I will then update our scripts/{et al.}.

am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
dbd4965 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.
Related Issue: sass#655.
PR URL: <undefined>.
@am11 am11 mentioned this issue Feb 10, 2015
Merged
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
b6ee845 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.
Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
b66aa3b 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
f5f05cd 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
a919a7a 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
57c9078 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
b2a5443 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
8cf4540 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
269f4b4 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
b8a6309 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
0923568 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
2be25ba 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
am11 added a commit to am11/node-sass that referenced this issue Feb 10, 2015
@am11
Build: Produces identifiable binary name.
4b5ebaf 
The new format is:
{platform}-{arch}-{runtime}-{major.minor}
where major and minor version belong to
the runtime.

Related Issue: sass#655.
PR URL: sass#657.
@am11 am11 mentioned this issue Feb 11, 2015
Closed
@am11
Copy link
Contributor Author

am11 commented Feb 11, 2015

@xzyfer, I am building the Windows binaries now for node.js (v0.10 and v0.12) and io.js (v1.1).
Would you rebuild the binaries for Mac as well; targeting the same (sub) matrix?

Note the last batch of commits has a minor change in binding code, hence rebuild the binary for node.js v0.10 and v0.12 is required.

Note 2: you can use nvm to switch between node.js or io.js versions (without installing them manually).

Once this step is done, I will apply the (LibSass gcc 4.4.7) patch and build Linux binaries on CenOS 5.11.

am11 added a commit to am11/node-sass-binaries that referenced this issue Feb 12, 2015
@am11
Windows: Adds binary for v2.0.0.
4352ea0 
* node.js v0.10 ia32.
* node.js v0.10 x64.
* node.js v0.12 ia32.
* node.js v0.12 x64.
* io.js v0.12 ia32.
* io.js v0.12 x64.

PR URL: sass#28.
Related Issue: sass/node-sass#655.
am11 added a commit to am11/node-sass-binaries that referenced this issue Feb 12, 2015
@am11
Windows: Adds binary for v2.0.0.
41d8559 
* node.js v0.10 ia32.
* node.js v0.10 x64.
* node.js v0.12 ia32.
* node.js v0.12 x64.
* io.js v0.12 ia32.
* io.js v0.12 x64.

PR URL: sass#28.
Related Issue: sass/node-sass#655.
@am11
Copy link
Contributor Author

am11 commented Feb 12, 2015

With v2.0.0, here is the state of coverage matrix: https://github.com/sass/node-sass-binaries/releases/tag/v2.0.0.

@Turbo87, would you like to send a PR for moving the updated matrix to README, the way you proposed?

@browniefed
Copy link

👍 Yaye

@Turbo87
Copy link

Turbo87 commented Feb 12, 2015

@am11 sure, why not.

Turbo87 added a commit to Turbo87/node-sass-binaries that referenced this issue Feb 12, 2015
@Turbo87
README: Add compatibility/coverage matrix
0efda91 
as suggested in sass/node-sass#655
This was referenced Feb 12, 2015
Closed
Merged
@am11
Copy link
Contributor Author

am11 commented Feb 12, 2015

Updated the matrix for v2.0.1 in first post.

@am11 am11 mentioned this issue Feb 13, 2015
Merged
@am11 am11 added this to the Unknown milestone Feb 13, 2015
@chrisbenson chrisbenson mentioned this issue Feb 14, 2015
Closed
@bnb bnb mentioned this issue Feb 17, 2015
Closed
This was referenced Feb 19, 2015
Closed
Closed
Closed
Closed
@yous yous mentioned this issue Feb 22, 2015
Merged
@am11 am11 added the npm build label Feb 23, 2015
This was referenced Mar 2, 2015
Open
Closed
Closed
@saper
Copy link
Member

saper commented Mar 8, 2015

iojs 1.4.1 has upgraded v8 to 4.1.0.21 due to undisclosed security bug ( nodejs/node#952 ) - https://code.google.com/p/chromium/issues/detail?id=430201 (embargoed).

@am11
Copy link
Contributor Author

am11 commented Mar 16, 2015

The information in the original post is outdated.

For v3.0.0-alpha.0 (rebooted preview), please refer to node-sass-binaries repo's readme: https://github.com/sass/node-sass-binaries/blob/master/README.md.
(summary: io.js v1.0.0-v1.5.1 are supported for Linux, Mac and Windows and FreeBSD is available for node.js v0.12)

Once we refactor the docs (#730), we will most probably bring the coverage status to node-sass readme.

Thanks for your comments.

@am11 am11 closed this as completed Mar 16, 2015
@stephenplusplus stephenplusplus mentioned this issue Apr 20, 2015
Merged
@saper
Copy link
Member

saper commented May 4, 2015

So, we now have io.js 2.0.0, which defines NODE_MODULE_VERSION to 44

@xzyfer xzyfer removed this from the Unknown milestone Sep 17, 2015
@renovate renovate bot mentioned this issue Jun 6, 2021
Closed
1 task
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this issue Apr 7, 2024
@xzyfer
Merge pull request sass#655 from xzyfer/fix/issue_641
2e48c07 
Fix error for some selectors with interpolants
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Discussion - Proposal npm build
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Martii @Turbo87 @saper @xzyfer @browniefed @am11