Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

API: Retire image_path option #702

Closed
am11 opened this issue Feb 24, 2015 · 6 comments
Closed

API: Retire image_path option #702

am11 opened this issue Feb 24, 2015 · 6 comments
Labels
Module - API Module - CLI Release - Breaking Change
Milestone
v3.0.0

Comments

@am11
Copy link
Contributor

am11 commented Feb 24, 2015

Based on sass/libsass#834 and sass/libsass#489.

Related: #224.
@am11 am11 added this to the 2.1 milestone Feb 24, 2015
@am11 am11 mentioned this issue Feb 24, 2015
Merged
@xzyfer
Copy link
Contributor

xzyfer commented Feb 24, 2015

🎉 🚀

@xzyfer
Copy link
Contributor

xzyfer commented Feb 24, 2015

Off topic, but if we're introducing breaking changes can we changed the milestone to 3.0. Packages that don't follow semver are the bane of npm.

@am11
Copy link
Contributor Author

am11 commented Feb 24, 2015

I agree. With all the new features in LibSass and the custom functions feature coming to node-sass the vNext is going to be a HUGE one! 📣

am11 added a commit to am11/node-sass that referenced this issue Feb 25, 2015
@am11
API: Retires non-standard image-path option.
c1d433f 
Issue URL: sass#702.
PR URL: sass#704.
am11 added a commit to am11/node-sass that referenced this issue Feb 25, 2015
@am11
API: Retires non-standard image-path option.
0c586e1 
Issue URL: sass#702.
PR URL: sass#704.
@am11 am11 mentioned this issue Feb 25, 2015
Merged
am11 added a commit to am11/node-sass that referenced this issue Feb 25, 2015
@am11
API: Retires non-standard image-path option.
5cf107b 
Issue URL: sass#702.
PR URL: sass#704.
@am11
Copy link
Contributor Author

am11 commented Feb 28, 2015

Revoked by 5cf107b via #704.

@am11 am11 closed this as completed Feb 28, 2015
@mgreter mgreter mentioned this issue Mar 25, 2015
Closed
@shunwen shunwen mentioned this issue Sep 9, 2015
Closed
@justin808
Copy link

What is the replacement for imagePath? Are there any upgrade guidelines?

@xzyfer
Copy link
Contributor

xzyfer commented Sep 9, 2015

No. It was removes because it's not in Ruby Sass. You can use a custom
function or sass-eyeglass which has this.
On 9 Sep 2015 19:00, "Justin Gordon" notifications@github.com wrote:

What is the replacement for imagePath? Are there any upgrade guidelines?

—
Reply to this email directly or view it on GitHub
#702 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Module - API Module - CLI Release - Breaking Change
Projects
None yet
Milestone
v3.0.0
Development

No branches or pull requests
3 participants
@xzyfer @justin808 @am11