Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Fix final Node 6 deprecation warnings #1498

Merged
merged 1 commit into from
Apr 28, 2016

Conversation

xzyfer
Copy link
Contributor

@xzyfer xzyfer commented Apr 28, 2016

This was partially addressed by bumping NAN in #1496.

nodejs/node#6216
https://codereview.chromium.org/1839983002/patch/1/10002

Fixes #1484

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 28, 2016

I've asserted this passes on all supported version of Node, or 32 and 64bit archs, on Windows, OSX and Linux. Going to ship this.

@xzyfer xzyfer force-pushed the feat/nan-deprecation-warnings branch from e77f586 to beb5c74 Compare April 28, 2016 15:01
@xzyfer xzyfer merged commit ff17933 into sass:master Apr 28, 2016
@xzyfer xzyfer deleted the feat/nan-deprecation-warnings branch April 28, 2016 15:21
@raphaelokon
Copy link

Do you have any ETA for the next release containing this @xzyfer?

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 28, 2016

A couple days. Building a release takes 24hours alone.

@elado
Copy link

elado commented Apr 28, 2016

@xzyfer (just a question, not a complaint or anything:) why does it take so long? Is it compiled for each node version separately?

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 29, 2016

@elado since we're a native extensions we need to build the 56 binaries required for each release. This requires a number of VMs and decent amount of compute time. Few other native extensions do this but compiling node sass is non-trival so we try to do most of the work for people.

@raphaelokon
Copy link

@xzyfer 👏 for the info. Can't wait to have my node env working again with node-sass :-)

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 29, 2016

Fwiw node Sass still works fine. The stack track is just a warning and
doesn't stop mode Sass working.
On 29 Apr 2016 6:53 PM, "Raphael" notifications@github.com wrote:

@xzyfer https://github.com/xzyfer 👏 for the info. Can't wait to have
my node env working again with node-sass :-)


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#1498 (comment)

mcampa pushed a commit to mcampa/node-sass that referenced this pull request Apr 21, 2017
mcampa pushed a commit to mcampa/node-sass that referenced this pull request Apr 26, 2017
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Add error for mixins without `@content` statement
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants