-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix final Node 6 deprecation warnings #1498
Conversation
This was partially addressed by bumping NAN in sass#1496. nodejs/node#6216 https://codereview.chromium.org/1839983002/patch/1/10002 Fixes sass#1484
I've asserted this passes on all supported version of Node, or 32 and 64bit archs, on Windows, OSX and Linux. Going to ship this. |
e77f586
to
beb5c74
Compare
Do you have any ETA for the next release containing this @xzyfer? |
A couple days. Building a release takes 24hours alone. |
@xzyfer (just a question, not a complaint or anything:) why does it take so long? Is it compiled for each node version separately? |
@elado since we're a native extensions we need to build the 56 binaries required for each release. This requires a number of VMs and decent amount of compute time. Few other native extensions do this but compiling node sass is non-trival so we try to do most of the work for people. |
@xzyfer 👏 for the info. Can't wait to have my node env working again with |
Fwiw node Sass still works fine. The stack track is just a warning and
|
This was partially addressed by bumping NAN in sass#1496. nodejs/node#6216 https://codereview.chromium.org/1839983002/patch/1/10002 Fixes sass#1484
This was partially addressed by bumping NAN in sass#1496. nodejs/node#6216 https://codereview.chromium.org/1839983002/patch/1/10002 Fixes sass#1484
Add error for mixins without `@content` statement
This was partially addressed by bumping NAN in #1496.
nodejs/node#6216
https://codereview.chromium.org/1839983002/patch/1/10002
Fixes #1484