This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Libsass 2b8a17a #2714
Closed
Libsass 2b8a17a #2714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2019
Open
saper
reviewed
Aug 6, 2019
| "object-merge": "^2.5.1", | ||
| "read-yaml": "^1.0.0", | ||
| "rimraf": "^2.5.2", | ||
| "sass-spec": "https://github.com/sass/sass-spec.git#dc2d573", |
There was a problem hiding this comment.
There seems to be a bit too much whitespace change, can you check?
You need to figure out the right commit from the https://github.com/sass/sass-spec repository, it will be probably close to the master branch.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to latest libsass
node-sass mocha tests don't pass, I'm not sure how to reconcile node-sass tests against libsass changes between Nov 11, 2018 and current libsass#2b8a17a. Unless I'm misunderstanding the failing node-sass tests I'm not confident that node-sass should have it's own set of render output tests, it should probably depend on libsass tests if it's not.
5935 passing (18s)
753 pending
143 failing