Binary: Removes v8 version from the dir name #541
Conversation
Corresponds to: sass/node-sass#541.
Binary: Removes v8 version from the dir name
|
Is this a wise thing to do? Will the v8 API be stable enough that it'll work across many versions? |
|
Well we can't know that until later. BTW, we are using like 1% of the entire V8 API. 😜 But it's certainly better than letting the users experience this kind of issue: #535. Don't you agree ❕ ❓ 😉 |
|
If we don't have a binary available we should fall back to building from source rather than just 404ing bombing out. We don't officially support 0.11.x but that won't stop people trying to use it and reporting issues with it. |
|
Cool! That can be done fairly easily with the current architecture. But with v8 version slug gone, after downloading the binary for the OS-architecture under question we test it and fallback to building unless 90% of tests are passing. 404 case should be handled in similar manner. 👍 |
|
@andrew, this is exactly what's happening. I just tested it; in case of 404-not-found, it falls back to |
|
Cool beans! FYI I've got a debian wheezy virtual machine setup now, going to 🚢 a new point release later today with updated linux binaries and those recent install changes. |
|
Ops; shouldn't we wait for the "Cousin of Dragon" here https://github.com/sass/libsass/releases? 😄 Its seems like they libsass is ready and node-sass is almost there, so I guess its time to flip the switch! 😎 |
|
The current release is broken for lots of people, this should fix that before we go and introduce a load of other changes that will likely cause more support requests and headaches. I'd like to have a good stable version we can send people to, which is currently 1.0.3 (libsass 3.0.0). |
|
Makes sense! I will push the binaries for windows in the afternoon. |
|
@am11 I'm not talking about updating libsass, there haven't been any changes in master than need new binaries for mac or windows, just fixing up the linux ones that don't work on heroku or debian. |
|
Yup I know, with the current state of our master.. There was a report that v1.2.2 isn't working with W7 32bits. Perhaps the fresh binary built with relaxed compiler options do the trick? |
|
Yeah it can't hurt right! |
|
Yes only if it works! :D |
Fixes issue sass#541 with negative number output
Next, we need to reflect these changes on node-sass-binaries repo.