Don't run the release task until tests have passed (#745)

sass · Jun 26, 2023 · 9fb50a9 · 9fb50a9
1 parent 467243a
commit 9fb50a9
Showing 1 changed file with 9 additions and 10 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -4,7 +4,6 @@ on:
   push:
     branches: [main, 'feature.*']
   pull_request:
-    types: [reopened]
 
 concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
@@ -44,15 +43,15 @@ jobs:
   release:
     name: Deploy
     runs-on: ubuntu-latest
-    if:
-      github.event_name == 'push' &&
-        github.ref == 'refs/heads/main' &&
-        github.repository == 'sass/sass-site'
+    needs: [test, lint]
+    if: github.event_name == 'push' &&
+      github.ref == 'refs/heads/main' &&
+      github.repository == 'sass/sass-site'
 
     steps:
-    - uses: actions/checkout@v3
-      with:
-        token: ${{ secrets.GH_TOKEN }}
+      - uses: actions/checkout@v3
+        with:
+          token: ${{ secrets.GH_TOKEN }}
 
-    # Pushing to the production branch will trigger Netlify's release process.
-    - run: git push -f origin main:production
+      # Pushing to the production branch will trigger Netlify's release process.
+      - run: git push -f origin main:production