Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document new color spaces #1055

Merged
merged 2 commits into from
Jul 18, 2024
Merged

Document new color spaces #1055

merged 2 commits into from
Jul 18, 2024

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented May 17, 2024

See #672

@nex3 nex3 mentioned this pull request May 17, 2024
Open
2 tasks
@netlify Netlify
Copy link

netlify bot commented May 17, 2024 •
edited
Loading

✅ Deploy Preview for sass-lang ready!

Name Link
🔨 Latest commit e6b975d
🔍 Latest deploy log https://app.netlify.com/sites/sass-lang/deploys/668c67133083da000863d7ba
😎 Deploy Preview https://deploy-preview-1055--sass-lang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nex3 nex3 mentioned this pull request May 17, 2024
Open
13 tasks
@nex3 nex3 force-pushed the color-4 branch 3 times, most recently from d646034 to ad365db Compare May 24, 2024 00:03
@nex3 nex3 marked this pull request as ready for review June 6, 2024 00:31
@nex3 nex3 requested a review from jathak June 6, 2024 00:31
jathak
jathak approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@jathak jathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notice the Dart Sass version listed in the compatibility for all the new functionality is 1.78.0. Is that a placeholder until everything is ready to submit, or is the plan to release both the @import deprecation and color spaces in 1.78.0?

source/documentation/modules/color.md Outdated Show resolved Hide resolved
source/documentation/modules/color.md Show resolved Hide resolved
@nex3
Copy link
Contributor Author

nex3 commented Jul 8, 2024

I notice the Dart Sass version listed in the compatibility for all the new functionality is 1.78.0. Is that a placeholder until everything is ready to submit, or is the plan to release both the @import deprecation and color spaces in 1.78.0?

It's a placeholder, I just use the next unreleased version for color space stuff and bump it when I merge from main.

@nex3 nex3 merged commit f624279 into main Jul 18, 2024
9 checks passed
@nex3 nex3 deleted the color-4 branch July 18, 2024 01:21
nex3 added a commit that referenced this pull request Jul 18, 2024
@nex3
Revert "Document new color spaces (#1055)"
0e6ee6f 
This reverts commit f624279.
@nex3 nex3 mentioned this pull request Jul 18, 2024
Merged
nex3 added a commit that referenced this pull request Jul 18, 2024
@nex3
Revert "Document new color spaces (#1055)" (#1114)
e57d81e 
This reverts commit f624279.
nex3 added a commit that referenced this pull request Jul 18, 2024
@nex3
Revert "Revert "Document new color spaces (#1055)" (#1114)"
b11fd04 
This reverts commit e57d81e.
@nex3 nex3 restored the color-4 branch July 18, 2024 01:23
nex3 added a commit that referenced this pull request Jul 18, 2024
@nex3
Document new color spaces (#1055)
1f24149 
See #672
@nex3 nex3 mentioned this pull request Jul 18, 2024
Merged
mirisuzanne added a commit to oddbird/sass-site that referenced this pull request Sep 12, 2024
@mirisuzanne
Merge branch 'color-4' into color-space-post
3d6f27e 
* color-4:
  Document new color spaces (sass#1055)
nex3 added a commit that referenced this pull request Sep 18, 2024
@nex3 @mirisuzanne
Document new color spaces (#1055) (#1115)
3097289 
Document new color spaces (#1055)

See #672

Co-authored-by: Miriam Suzanne <miriam@oddbird.net>
jgerigmeyer added a commit to oddbird/sass-site that referenced this pull request Sep 20, 2024
@jgerigmeyer
Merge branch 'main' into resize-playground
0f4c3a8 
* main: (23 commits)
  [Playground] Click to Copy (sass#1177)
  Cut a release for a new Dart Sass version
  [Playground] Debug links (sass#1179)
  Add breaking change page for legacy-js-api (sass#1193)
  [Playground] Autocomplete (sass#1166)
  Add a breaking change page for color functions (sass#1192)
  Remove nonexisting `color.saturate()` function (sass#1190)
  Fix unprefixed `color.adjust()` name (sass#1188)
  Sort color functions alphabetically (sass#1187)
  Document color migrator (sass#1186)
  Cut a release for a new Dart Sass version
  Document new color spaces (sass#1055) (sass#1115)
  Cut a release for a new Dart Sass version
  Bump date-fns from 3.6.0 to 4.0.0 (sass#1181)
  Bump rollup from 4.21.2 to 4.21.3 (sass#1182)
  Bump @codemirror/autocomplete from 6.18.0 to 6.18.1 (sass#1183)
  Bump @typescript-eslint/eslint-plugin from 8.5.0 to 8.6.0 (sass#1185)
  Bump markdown-it-anchor from 9.1.0 to 9.2.0 (sass#1184)
  Fix footer not showing the latest versions. (sass#1178)
  [Playground] Code links (sass#1167)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathak jathak jathak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @jathak