Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the @use rule #364

Merged
merged 2 commits into from
Sep 4, 2019
Merged

Document the @use rule #364

merged 2 commits into from
Sep 4, 2019

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 2, 2019

Closes #361

@nex3 nex3 requested a review from jelbourn September 2, 2019 20:32
@nex3 nex3 temporarily deployed to sass-lang-pr-364 September 2, 2019 20:32 Inactive
source/documentation/at-rules/use.html.md.erb Show resolved Hide resolved
source/documentation/at-rules/use.html.md.erb Show resolved Hide resolved

The simplest `@use` rule is written `@use "<url>"`, which loads the module at
the given URL. Any CSS in modules you load will be included exactly once in your
compiled CSS, no matter how many times they're loaded.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this last sentence, how about

Any styles imported this way will appear exactly once in the compiled CSS output,
regardless of how many times those styles are imported"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done somewhat, although I want to avoid reserve the word "import" for use with @import in particular.

source/documentation/at-rules/use.html.md.erb Outdated Show resolved Hide resolved

## Finding the Module

It wouldn't be any fun to write out absolute URLs for every stylesheet you load,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I would tone down the subjective/conversational vibe here, but you can make that editorial call.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think part of the appeal of Sass is its holistic focus on the emotions of users, including having a friendlier tone in a few places in docs, especially explaining motivation for features which tends to be inherently subjective to a degree. I'm not opposed to avoiding this if it's making the documentation concretely harder to understand, but I don't want to just avoid it on principle.

source/documentation/at-rules/use.html.md.erb Outdated Show resolved Hide resolved
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nex3 nex3 merged commit b27ef20 into feature.use Sep 4, 2019
@nex3 nex3 deleted the use branch September 4, 2019 22:24
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants