-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the @use rule #364
Conversation
Closes #361
|
||
The simplest `@use` rule is written `@use "<url>"`, which loads the module at | ||
the given URL. Any CSS in modules you load will be included exactly once in your | ||
compiled CSS, no matter how many times they're loaded. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this last sentence, how about
Any styles imported this way will appear exactly once in the compiled CSS output,
regardless of how many times those styles are imported"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done somewhat, although I want to avoid reserve the word "import" for use with @import
in particular.
|
||
## Finding the Module | ||
|
||
It wouldn't be any fun to write out absolute URLs for every stylesheet you load, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I would tone down the subjective/conversational vibe here, but you can make that editorial call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think part of the appeal of Sass is its holistic focus on the emotions of users, including having a friendlier tone in a few places in docs, especially explaining motivation for features which tends to be inherently subjective to a degree. I'm not opposed to avoiding this if it's making the documentation concretely harder to understand, but I don't want to just avoid it on principle.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #361