Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate out building and updating the shadow repo #750

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Jun 26, 2023

We can't update it directly from PRs because external PRs are run in
an untrusted context without secrets access. Instead, as suggested by
this article, we build the site in an untrusted workflow and then
push it in a trusted workflow that has no access to the PR contents
itself.

We can't update it directly from PRs because external PRs are run in
an untrusted context without secrets access. Instead, as suggested by
[this article], we build the site in an untrusted workflow and then
push it in a trusted workflow that has no access to the PR contents
itself.

[this article]: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/,
@github-actions
Copy link

View diff of compiled files (may take a few minutes): https://github.com/sass/sass-site-built/compare/main..shadow-repo

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for sass-lang ready!

Name Link
🔨 Latest commit 2283051
🔍 Latest deploy log https://app.netlify.com/sites/sass-lang/deploys/649a1b8cde55a500080db91a
😎 Deploy Preview https://deploy-preview-750--sass-lang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nex3 nex3 marked this pull request as ready for review June 26, 2023 23:19
@nex3 nex3 requested a review from jathak June 26, 2023 23:19
@nex3 nex3 merged commit 51b6d44 into main Jun 27, 2023
@nex3 nex3 deleted the shadow-repo branch June 27, 2023 20:41
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
We can't update it directly from PRs because external PRs are run in
an untrusted context without secrets access. Instead, as suggested by
[this article], we build the site in an untrusted workflow and then
push it in a trusted workflow that has no access to the PR contents
itself.

[this article]: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/,
asaf400 pushed a commit to asaf400/ass-site that referenced this pull request Apr 18, 2024
We can't update it directly from PRs because external PRs are run in
an untrusted context without secrets access. Instead, as suggested by
[this article], we build the site in an untrusted workflow and then
push it in a trusted workflow that has no access to the PR contents
itself.

[this article]: https://securitylab.github.com/research/github-actions-preventing-pwn-requests/,
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants