Add @use member usage and load error tests #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also cleans up the existing specs and adds a few for missing cases.
Consolidate and flesh out @import load specs
|
You only need to review the commits after the merge; everything else was already reviewed when it landed on |
nshahan
reviewed
Feb 22, 2019
| @function member() {@return from other2} | ||
|
|
||
| <===> conflict/error | ||
| Error: Multiple global modules have a function named "member". |
There was a problem hiding this comment.
I don't see where this error is coming from in dart-sass but could it include the names of the modules that have conflicting functions? It would make it easier to track down when many modules are used.
There was a problem hiding this comment.
There's already a TODO for that: https://github.com/sass/dart-sass/blob/5a64dec4ec54ef4fc8fdf0ca0c16a83fec81463b/lib/src/async_environment.dart#L589
| ================================================================================ | ||
| <===> conflict/extension/scss_and_css/input.scss | ||
| // This import can't be resolved because it could refer to either the ".sass" or | ||
| // ".css" file. |
There was a problem hiding this comment.
Same question here as I added to sass/dart-sass#603. Might cause confusion on your second build?
nshahan
approved these changes
Feb 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[skip dart-sass]