Materialize parent HRX directories if necessary #1408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an HRX directory is being materialized with #with_real_files and it contains a file that reaches outside itself (with `../`), materialize its parent directory as well. This allows individual tests to share utility libraries that are defined in the same HRX archive.
rambleraptor
approved these changes
Jun 18, 2019
| # Returns whether `file` contains enough `../` references to reach outside | ||
| # this directory. | ||
| def _reaches_out?(file) | ||
| depth = file.path.count("/") |
There was a problem hiding this comment.
Do we know if file paths have trailing slashes?
There was a problem hiding this comment.
The HRX spec guarantees that they won't; otherwise they'd be parsed as HRX::Directorys instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an HRX directory is being materialized with #with_real_files and it
contains a file that reaches outside itself (with
../), materializeits parent directory as well. This allows individual tests to share
utility libraries that are defined in the same HRX archive.