Allow arguments to be passed to any command #1426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreter
force-pushed
the
feature/proxy-cmd-args
branch
from
d8b55c2
to
7fbd056
Compare
mgreter
force-pushed
the
feature/proxy-cmd-args
branch
2 times, most recently
from
86620d0
to
d144baf
Compare
mgreter
changed the title
mgreter
force-pushed
the
feature/proxy-cmd-args
branch
3 times, most recently
from
65d0a3a
to
07102ee
Compare
Renames `--dart-args` to `--cmd-args`
mgreter
force-pushed
the
feature/proxy-cmd-args
branch
from
eb1d594
to
07102ee
Compare
|
CI is at least green again ... |
|
Please wait to get a review before landing PRs. If you want to build further PRs on top of them, that's fine; you can just rebase the upstream commit away once it lands. This broke Dart Sass's CI, which was relying on the |
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 10, 2019
nex3
added a commit
to sass/dart-sass
that referenced
this pull request
Jul 10, 2019
This was referenced Jul 12, 2019
This was referenced Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames
--dart-argsto--cmd-argsAllows libsass to work around #1427.
@nex3 I probably will merge this very soon since #1427 is quite a blocker ATM for me.
I think this change makes sense even on its own, but feel free to change it as you see fit.