Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to libsass beta version #20

Merged
merged 3 commits into from
Oct 14, 2015
Merged

update to libsass beta version #20

merged 3 commits into from
Oct 14, 2015

Conversation

bolandrm
Copy link
Member

@bolandrm bolandrm commented Oct 2, 2015

Don't plan to merge until the official 3.3.0 release.

def optional_arguments(path, optional = "bar")
Script::String.new("#{path.value}/#{optional}", :string)
def optional_arguments(path, optional = nil)
optional ||= Script::String.new("bar")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edward this was the only functionality that really changed. I believe for optional values we should be specifying them as script/value objects. Might be breaking change for you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bolandrm that is an excellent question. I’ll test it out on Monday and follow up.

CC @rafaelfranca since you should know about this stuff too.

@bolandrm
Copy link
Member Author

Doing a beta release so we can test this a bit.

bolandrm added a commit that referenced this pull request Oct 14, 2015
update to libsass beta version
@bolandrm bolandrm merged commit cb36fb5 into master Oct 14, 2015
@bolandrm bolandrm deleted the new_libsas_version branch October 14, 2015 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants