fix: remove useCallback hooks in favour of mount-time references

sassoftware · Nov 3, 2023 · 3d85621 · 3d85621
1 parent 00b749a
commit 3d85621
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/components/ConfigEditor.tsx b/src/components/ConfigEditor.tsx
@@ -3,7 +3,7 @@
 	SPDX-License-Identifier: Apache-2.0
 */
 
-import React, {useCallback, useEffect, useMemo, useRef} from 'react';
+import React, {useEffect, useMemo, useRef} from 'react';
 import {Checkbox, HorizontalGroup, InlineLabel, Select, VerticalGroup} from '@grafana/ui';
 import {DataSourcePluginOptionsEditorProps, SelectableValue} from '@grafana/data';
 import {EspDataSourceOptions} from '../types';
@@ -32,15 +32,15 @@ export function ConfigEditor({options, onOptionsChange}: DataSourcePluginOptions
         return matchingOption ? matchingOption : {value: discoveryServiceUrl, label: discoveryServiceUrl};
     }
 
-    const changePropOptions = useCallback((change: Object) => {
+    const changePropOptions = (change: Object) => {
         const newOptions = {...options, ...change};
         onOptionsChange(newOptions);
-    }, [options, onOptionsChange])
+    }
 
-    const changePropOptionsJsonData = useCallback((change: Object) => {
+    const changePropOptionsJsonData = (change: Object) => {
         const newJsonData = {...jsonData, ...change};
         changePropOptions({jsonData: newJsonData});
-    }, [changePropOptions, jsonData])
+    }
 
     const handleDiscoveryServiceProviderChange = (selectedOption: SelectableValue<string>) => {
         changePropOptions({url: selectedOption.value});