Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoring services #204

Closed
wants to merge 83 commits into from
Closed

Scoring services #204

wants to merge 83 commits into from

Conversation

djm21
Copy link
Collaborator

@djm21 djm21 commented Oct 28, 2024

No description provided.

samyarpotlapalli and others added 30 commits June 20, 2024 13:02
@samyarpotlapalli @smlindauer
testing
27bb5b8
@samyarpotlapalli @smlindauer
"Testing."
44dc0fb
@samyarpotlapalli @smlindauer
Fixing comments
3df1df9
@samyarpotlapalli @smlindauer
Getting a model and input mapping
407427b
@samyarpotlapalli @smlindauer
Creating score definition JSON information
8af52b4
@samyarpotlapalli @smlindauer
Adding comments and adjusting for various API call and responses
1461ded
@samyarpotlapalli @smlindauer
Exits program after an error
07d6c93
@samyarpotlapalli
Added original score_execution implementation
2110d66
@smlindauer
refactor: swap in Service class for ScoreDefinitions class
3e46e78
@samyarpotlapalli
Refactoring and adjusting for invalid HTTP status codes
210bf6c
@samyarpotlapalli
Raising exception if input file for table does not exist
dddc116
@samyarpotlapalli
Added import statements
e697c25
@samyarpotlapalli
Rename score_execution.py to src/_services/score_execution.py
ba59858
@samyarpotlapalli
Rename score_definition.py to src/sasctl/_services/score_definition.py
ba11e11
@smlindauer
refactor: move score_execution to appropriate directory
409167c
@smlindauer
refactor: remove redundant score_definition.py; leave plural form to …
a7e6288 
…match API
@smlindauer
chore: apply black linter
8d55624
@smlindauer
refactor: add comments and proper indenting for classmethod
6e6390d
@smlindauer
fix: proper call to model_repository in score_definitions.py
fcb19ab
@smlindauer
fix: proper call to cls for score execution and black formatting
a38f4a7
@smlindauer
First draft of unit testing for score definitions and score execution
4087b59
@samyarpotlapalli
Added comments for test cases in test.score_definitions.py and starte…
43f2ab1 
…d building out functions/calls to test for score_execution
@samyarpotlapalli
Testing requests approach to pass get_model test
9e43960
@smlindauer
refactor: adjust score_definitions.py for easier unit testing
b4692a0
@smlindauer
test: update unit tests and put in draft score_definitions test
c68cb8b
@samyarpotlapalli @smlindauer
Formatting score definitions and running binary classification to tes…
a73a08c 
…t scoring services on an example notebook
@samyarpotlapalli @smlindauer
Adding fail cases for get_table and upload_file
2770514
@samyarpotlapalli @smlindauer
First version of all test cases for score definition
e433643
@samyarpotlapalli @smlindauer
Reformatting
00f358e
@samyarpotlapalli @smlindauer
Reformatting with black version 24.4.2
2ef46a4
smlindauer and others added 28 commits October 21, 2024 12:05
@smlindauer
reformat: adjust score_execution.py to use same style of internal ser…
000d123 
…vice call
@smlindauer
tests: fix test_score_execution json reading error
f0984c4
@samyarpotlapalli @smlindauer
Adding frameworks for the rest of score_execution unit tests
ae41977
@samyarpotlapalli @smlindauer
Pushing with all successful test cases
2a3607f
@samyarpotlapalli @smlindauer
Fixed mapping issue in score_definitions
410b9cc
@samyarpotlapalli @smlindauer
Fixed import statements
3af08ff
@samyarpotlapalli @smlindauer
Removed extra print statement and Class call
172dddd
@samyarpotlapalli @smlindauer
Corrected status code comparisons
26fe616
@samyarpotlapalli @smlindauer
Fixed incorrect get_table syntax
2a58f5f
@samyarpotlapalli @smlindauer
filter changed
3cd5a2a
@smlindauer
chore: add score-definitions and score-execution service into service…
a68d2d3 
…s.py
@smlindauer
chore: fix spelling errors
913fe03
@smlindauer
fix: proper call to the object uri in modelManagement for score defin…
2f54f8c 
…itions
@smlindauer
feat: change base score definition to use CAS Gateway
f250b5f
@smlindauer
refactor: swap model_id to model for ease of use in argument choice
4f9ab4d
@smlindauer
feat: add new task to score models in SAS Model Manager
fa248a2
@samyarpotlapalli @smlindauer
Added docstrings and removed list_executions unit tests in test_score…
bde6304 
…_execution.py
@samyarpotlapalli @smlindauer
Added this to fix code quality linting error
21808ec
@samyarpotlapalli @smlindauer
Edited test_score_definitions for syntax issue
73092a4
@samyarpotlapalli @smlindauer
black reformatting
7520ca0
@samyarpotlapalli @smlindauer
checking black formatting
63c2068
@samyarpotlapalli @smlindauer
added cas gateway optional parameter
b88c928
@samyarpotlapalli @smlindauer
Add files via upload
c8b1c70 
Updated example with score testing
@samyarpotlapalli @smlindauer
score testing example
b7347b3
@smlindauer
Merge branch 'refs/heads/master' into scoring_services
7b23992 
# Conflicts:
#	examples/pzmm_binary_classification_model_import.ipynb
#	src/sasctl/__init__.py
#	src/sasctl/tasks.py
#	tests/conftest.py
#	tox.ini
@samyarpotlapalli
pushing correct version
b7210ab
@djm21
Use gateway with score_model_with_cas call
b3f4358
@djm21
black reformatting
fa4de17
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@djm21 djm21 closed this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@djm21 @samyarpotlapalli @smlindauer @SophiaRowland @kaponte75