Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (IAC-925) Added an option in IAC AWS to use a single AZ #192

Closed
wants to merge 18 commits into from

Conversation

anthoday
Copy link
Contributor

@anthoday anthoday commented Mar 8, 2023

Improvements

The 'enable_multi_zone' flag has been implemented to enable customers to deploy EKS worker nodes across multiple availability zones in AWS. Additionally, the option to deploy EKS worker nodes into a single availability zone has been added.

Changes

  • When 'enable_multi_zone' is set to 'true', the EKS cluster will be deployed across multiple availability zones defined in the 'module.vpc.private_subnets' list.
  • When 'enable_multi_zone' is set to 'false', the EKS cluster will only be deployed in the first availability zone in the 'module.vpc.private_subnets' list.

Testing

See internal ticket for details and test artifacts:

Scenario Provider .tfvars file k8s Version Multi-Zone Flag 'false' : Results Multi-Zone Flag 'true' : Results
1 AWS sample-input.tfvars 1.23 Using the AWS Console - validated that all EKS nodes are deployed in the same zone.  Using the AWS Console - validated that all EKS nodes are deployed in multiple zones.
2 AWS sample-input-connect.tfvars 1.23 Using the AWS Console - validated that all EKS nodes are deployed in the same zone.  Using the AWS Console - validated that all EKS nodes are deployed in multiple zones.
3 AWS sample-input-custom-data.tfvars 1.23 Using the AWS Console - validated that all EKS nodes are deployed in the same zone. Using the AWS Console - validated that all EKS nodes are deployed in multiple zones. 
4 AWS sample-input-defaults.tfvars 1.23 Using the AWS Console - validated that all EKS nodes are deployed in the same zone. Using the AWS Console - validated that all EKS nodes are deployed in multiple zones. 
5 AWS sample-input-gpu.tfvars 1.23 Using the AWS Console - validated that all EKS nodes are deployed in the same zone. Using the AWS Console - validated that all EKS nodes are deployed in multiple zones. 
6 AWS sample-input-ha.tfvars 1.23 Using the AWS Console - validated that all EKS nodes are deployed in the same zone. Using the AWS Console - validated that all EKS nodes are deployed in multiple zones.
7 AWS sample-input-minimal.tfvars 1.23 Using the AWS Console - validated that all EKS nodes are deployed in the same zone. Using the AWS Console - validated that all EKS nodes are deployed in multiple zones. 
8 AWS sample-input-singlestore.tfvars 1.23 Using the AWS Console - validated that all EKS nodes are deployed in the same zone. n/a

@anthoday anthoday added the enhancement New feature or request label Mar 8, 2023
@anthoday anthoday self-assigned this Mar 8, 2023
@anthoday anthoday marked this pull request as ready for review March 9, 2023 22:45
@anthoday anthoday changed the title (IAC-918): Added an option in IAC AWS to use a single AZ (IAC-925): Added an option in IAC AWS to use a single AZ Mar 9, 2023
@anthoday anthoday changed the title (IAC-925): Added an option in IAC AWS to use a single AZ feat: (IAC-925) Added an option in IAC AWS to use a single AZ Mar 10, 2023
@anthoday anthoday changed the title feat: (IAC-925) Added an option in IAC AWS to use a single AZ feat: (IAC-918) (IAC-925) Added an option in IAC AWS to use a single AZ Mar 10, 2023
Base automatically changed from iac-168 to staging March 11, 2023 00:06
@anthoday anthoday changed the title feat: (IAC-918) (IAC-925) Added an option in IAC AWS to use a single AZ feat: (IAC-925) Added an option in IAC AWS to use a single AZ Jun 23, 2023
@jarpat
Copy link
Contributor

jarpat commented Sep 21, 2023

Keeping this PR open for now, but pulling the changes/diffs into a new working branch (IAC-1174) based off staging. This seems easier than trying to rebase it.

@jarpat
Copy link
Contributor

jarpat commented Sep 26, 2023

Superseded by #234

@jarpat jarpat closed this Sep 26, 2023
@jarpat jarpat deleted the IAC-918 branch November 2, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants