fix: (IAC-923) Update Node Pool IAM Role Names to Include Prefix #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riragh
approved these changes
Sep 19, 2023
thpang
approved these changes
Sep 19, 2023
dhoucgitter
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the naming of the node pool IAM roles. Before this change the roles were an autogenerated name based off just the node pool name which made them hard to track, especially if you are working with multiple clusters. This change makes it so that the name will now include the
prefixvalue in additional to the node names when the roles are created.e.g. the roles are now
cas-eks-node-group-[timestamp-unique]->my-cool-prefix-cas-eks-node-groupThis is not a breaking change either, if you rerun apply using this PR using an earlier release the node pool IAM roles will just be replaced with ones with the updated names and associated with the existing node pools.
Tests