feat: (IAC-1078) Linting Updates and Code Formatting #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarpat
commented
Sep 27, 2023
jarpat
commented
Sep 27, 2023
thpang
reviewed
Sep 27, 2023
thpang
approved these changes
Sep 28, 2023
Correct the warning is no longer thrown by tflint. The |
riragh
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updated the linting workflow config so that branches named with the path pattern (e.g.
feat/1078) will also have pipeline automatically triggered for them.Additionally, updated the linting workflow config so that
tflintwill now get run against the terraform files under./modules. In doing so additional formatting warnings appeared which was also resolved.No functional changes, just formatting.
Tests